Workflow thread context has no current thread#2964
Draft
dplyukhin wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Remove "this should never happen" message from an event that sometimes happens: a task might exceed the potential deadlock timeout before it even gets
runif it takes too long to find a thread to do the work. It's unclear how to avoid this situation, so I've updated the documentation for potential deadlock timeout to account for this.Why?
Current documentation and error messages are misleading.
Checklist
Closes WorkflowThreadContext has no currentThread in RUNNING state #2959
How was this tested: Added tests to show that a tasks could potentially be locked out of the thread pool forever.
Any docs updates needed? I don't think so, but potentially TMPRL1101 could be more explicit about this.